Skip to content

fix isRecursiveCall failing on flyout blocks #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix isRecursiveCall failing on flyout blocks #4940

wants to merge 1 commit into from

Conversation

FurryR
Copy link

@FurryR FurryR commented Oct 1, 2024

Resolves

image

Clicking "b" in the flyout will cause exceptions:

Uncaught TypeError: Cannot read properties of undefined (reading 'opcode')
    at n.isRecursiveCall (projects.bundle.js:2:4755076)
    at l.stepToProcedure (projects.bundle.js:2:4743915)
    at e.exports.startProcedure (projects.bundle.js:2:4691130)
    at e.exports.call (projects.bundle.js:2:4674841)
    at e.exports (projects.bundle.js:2:4712562)
    at l.stepThread (projects.bundle.js:2:4743130)
    at l.stepThreads (projects.bundle.js:2:4742334)
    at U._step (projects.bundle.js:2:4735971)
    at projects.bundle.js:2:4740977

Proposed Changes

Fixed the issue by adding flyoutBlocks as a fallback.
This patch was originally from TurboWarp#227.

Reason for Changes

I don't know. For better user experience?

Test Coverage

N/A

@FurryR FurryR closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FurryR